Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kcopy): truncated text should have max-width on tooltip #2388

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix(kcopy): truncated text should have max-width on tooltip #2388

merged 1 commit into from
Sep 13, 2024

Conversation

Justineo
Copy link
Contributor

Summary

Added max-width for the tooltip for <KCopy>. I currently set it to 500px , same as the copy button tooltip. Not sure if we have any design guideline here.

kongponents/src/components/KCopy/KCopy.vue

Lines 29 to 34 in aa5192b

<KTooltip
class="text-icon-wrapper"
max-width="500px"
placement="bottom-start"
:text="tooltipText"
>

Before:

image

After:

image

@Justineo Justineo requested a review from a team as a code owner September 11, 2024 07:02
@netlify Netlify
Copy link

netlify bot commented Sep 11, 2024 •
edited
Loading

✅ Deploy Preview for kongponents-sandbox ready!

Name Link
🔨 Latest commit d327666
🔍 Latest deploy log https://app.netlify.com/sites/kongponents-sandbox/deploys/66e1407fb9d6e9000871aca0
😎 Deploy Preview https://deploy-preview-2388--kongponents-sandbox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Sep 11, 2024

✅ Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit d327666
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/66e1407eca74f100082ce6d0
😎 Deploy Preview https://deploy-preview-2388--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

portikM
portikM approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@portikM portikM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Justineo Justineo merged commit 43cc04f into main Sep 13, 2024
9 checks passed
@Justineo Justineo deleted the fix/kcopy-tooltip-max-width branch September 13, 2024 02:05
kongponents-bot pushed a commit that referenced this pull request Sep 13, 2024
@semantic-release-bot
chore(release): 9.6.5 [skip ci]
f61ed79 
## [9.6.5](v9.6.4...v9.6.5) (2024-09-13)

### Bug Fixes

* **kcodeblock:** keyboard shortcut for copy should work ([#2385](#2385)) ([d1bd965](d1bd965))
* **kcopy:** truncated text should have max-width on tooltip ([#2388](#2388)) ([43cc04f](43cc04f))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 9.6.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kongponents-bot
Copy link
Collaborator

Preview package from this PR in consuming application

In consuming application project install preview version of kongponents generated by this PR:

@kong/kongponents@pr-2388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@portikM portikM portikM approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Justineo @kongponents-bot @portikM